Skip to content

Add TextJoinSubstitution #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

bektaskemal
Copy link

@bektaskemal bektaskemal commented Mar 19, 2024

Addresses #741.
Don't use PythonExpression to join strings and be able to set seperators.

Signed-off-by: Kemal Bektas <[email protected]>
@christophebedard
Copy link
Member

Thanks for the PR.

Since this is specifically intended for PathJoinSubstitution, I don't think this is the right solution. Substitutions are already meant to be concatenated. I think the solution is to improve PathJoinSubstitution. Please see #838.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants